Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we use the up-to-date version of Folder in RefreshController #2025

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

KevinBoulongne
Copy link
Contributor

There is a Sentry issue saying that we get Messages from the wrong Folder when we refresh Folders.
Can't see why for now, but it seems we get the wrong Folder ?? There is an issue with the folder ID.

This PR is trying to make sure we use the correct Folder so we get the correct Messages.

@KevinBoulongne KevinBoulongne added the bug Something isn't working label Aug 29, 2024
@KevinBoulongne KevinBoulongne requested a review from a team August 29, 2024 07:31
@KevinBoulongne KevinBoulongne added the quick A pull request consisting of a few lines label Aug 29, 2024
@KevinBoulongne KevinBoulongne force-pushed the folder-in-RefreshController branch from 93be151 to d10e215 Compare August 29, 2024 10:56
@KevinBoulongne KevinBoulongne changed the title Use getUpToDateFolder() instead of findLatest() in RefreshController Make sure we use the up-to-date version of Folder in RefreshController Aug 30, 2024
Copy link

sonarqubecloud bot commented Sep 2, 2024

@KevinBoulongne KevinBoulongne merged commit 6b097a1 into master Sep 2, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the folder-in-RefreshController branch September 2, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quick A pull request consisting of a few lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants